fix: fixing wrong identifiers in payload for twitter ads destination

[manish339k]

What are the changes introduced in this PR?

x expects IP address is required to be passed in conjunction with another identifier (twclid, email address, phone number or user agent). and User Agent is required to be passed in conjunction with another identifier (twclid, email address, phone number or IP address).
ref: https://developer.x.com/en/docs/x-ads-api/measurement/web-conversions/api-reference/conversions
Previously implementation was wrong due to which we were getting error while sending the events with ip_address or/and user_agent. This PR fixes this issue.

What is the related Linear task?

Resolves INT-3052

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review

---

Developer checklist

• My code follows the style guidelines of this project

• No breaking changes are being introduced.

• All related docs linked with the PR?

• All changes manually tested?

• Any documentation changes needed with this change?

• Is the PR limited to 10 file changes?

• Is the PR limited to one linear task?

• Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

• Is the type of change in the PR title appropriate as per the changes?

• Verified that there are no credentials or confidential data exposed with the changes.

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/86/index.html

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.05%. Comparing base (69a1d6b) to head (4e11bb1).
Report is 10 commits behind head on develop.

Additional details and impacted files

@@           Coverage Diff            @@
##           develop    #3988   +/-   ##
========================================
  Coverage    91.04%   91.05%           
========================================
  Files          629      629           
  Lines        32841    32833    -8     
  Branches      7792     7787    -5     
========================================
- Hits         29901    29896    -5     
- Misses        2689     2718   +29     
+ Partials       251      219   -32     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/88/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/89/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/96/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/99/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/265/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/309/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/341/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/342/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/343/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/344/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/345/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/346/index.html

[koladilip]

This is related to #3909

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/348/index.html

[devops-github-rudderstack]

Allure Test reports for this run are available at:

• Allure Report: https://rudderlabs.github.io/rudder-transformer/349/index.html

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

[vinayteki95]

Small suggestion:
Instead of adding multiple spread operators, can we directly assign the values ?
+
Number.isFinite will check for NaN and finite floats

     const transformed = {};

      if (id) transformed.content_id = id;
      if (groupId) transformed.content_group_id = groupId;
      if (name) transformed.content_name = name;
      if (Number.isFinite(parseFloat(price))) transformed.content_price = parseFloat(price);
      if (type) transformed.content_type = type;
      if (Number.isFinite(parseInt(quantity, 10))) transformed.num_items = parseInt(quantity, 10);