Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: attentive tag bugsnag issue #3663

Merged
merged 6 commits into from
Aug 20, 2024
Merged

Conversation

shrouti1507
Copy link
Contributor

What are the changes introduced in this PR?

Write a brief explainer on your code changes.

What is the related Linear task?

Resolves INT-2549

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 requested a review from a team as a code owner August 16, 2024 08:34
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Aug 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.52%. Comparing base (ee5d523) to head (c46d29d).
Report is 7 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3663   +/-   ##
========================================
  Coverage    88.51%   88.52%           
========================================
  Files          584      584           
  Lines        31760    31811   +51     
  Branches      7566     7589   +23     
========================================
+ Hits         28112    28160   +48     
+ Misses        3356     3329   -27     
- Partials       292      322   +30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

anantjain45823
anantjain45823 previously approved these changes Aug 20, 2024
utsabc
utsabc previously approved these changes Aug 20, 2024
@sanpj2292
Copy link
Contributor

Can we check why component tests are failing ? And fix it ?!

anantjain45823
anantjain45823 previously approved these changes Aug 20, 2024
@shrouti1507 shrouti1507 dismissed stale reviews from anantjain45823 and utsabc via c4e337f August 20, 2024 10:29
@shrouti1507 shrouti1507 requested review from sivashanmukh and a team as code owners August 20, 2024 10:29
utsabc
utsabc previously approved these changes Aug 20, 2024
anantjain45823
anantjain45823 previously approved these changes Aug 20, 2024
@shrouti1507 shrouti1507 dismissed stale reviews from anantjain45823 and utsabc via 7fc3c1b August 20, 2024 11:35
Copy link

@shrouti1507 shrouti1507 merged commit 866dbf3 into develop Aug 20, 2024
20 of 21 checks passed
@shrouti1507 shrouti1507 deleted the fix.attentivetag_bugsnag branch August 20, 2024 11:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants