Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: braze source event mapping #3527

Merged
merged 6 commits into from
Jul 22, 2024
Merged

Conversation

shrouti1507
Copy link
Contributor

What are the changes introduced in this PR?

Braze source events are now being mapped in the UI. If not mapped the original event name is sent in the transformed event.

What is the related Linear task?

Resolves INT-2230

Please explain the objectives of your changes below

Put down any required details on the broader aspect of your changes. If there are any dependent changes, mandatorily mention them here

Any changes to existing capabilities/behaviour, mention the reason & what are the changes ?

N/A

Any new dependencies introduced with this change?

N/A

Any new generic utility introduced or modified. Please explain the changes.

N/A

Any technical or performance related pointers to consider with the change?

N/A

@coderabbitai review


Developer checklist

  • My code follows the style guidelines of this project

  • No breaking changes are being introduced.

  • All related docs linked with the PR?

  • All changes manually tested?

  • Any documentation changes needed with this change?

  • Is the PR limited to 10 file changes?

  • Is the PR limited to one linear task?

  • Are relevant unit and component test-cases added in new readability format?

Reviewer checklist

  • Is the type of change in the PR title appropriate as per the changes?

  • Verified that there are no credentials or confidential data exposed with the changes.

@shrouti1507 shrouti1507 self-assigned this Jul 3, 2024
@shrouti1507 shrouti1507 requested review from sivashanmukh and a team as code owners July 3, 2024 04:22
@shrouti1507 shrouti1507 added the enhancement New feature or request label Jul 3, 2024
@devops-github-rudderstack
Copy link
Contributor

Copy link

codecov bot commented Jul 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.12%. Comparing base (d085a08) to head (e584787).
Report is 54 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3527      +/-   ##
===========================================
- Coverage    88.13%   88.12%   -0.02%     
===========================================
  Files          585      584       -1     
  Lines        31566    31536      -30     
  Branches      7575     7558      -17     
===========================================
- Hits         27821    27791      -30     
- Misses        3400     3405       +5     
+ Partials       345      340       -5     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor Author

@shrouti1507 shrouti1507 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still have not removed braze from v0 yet ( hence the duplication check for sonar cloud is failing ), when this part is reviewed, will remove the v0 part

anantjain45823
anantjain45823 previously approved these changes Jul 5, 2024
Gauravudia
Gauravudia previously approved these changes Jul 5, 2024
Gauravudia
Gauravudia previously approved these changes Jul 8, 2024
anantjain45823
anantjain45823 previously approved these changes Jul 8, 2024
Copy link

@shrouti1507 shrouti1507 merged commit e357141 into develop Jul 22, 2024
16 of 17 checks passed
@shrouti1507 shrouti1507 deleted the feat.braze-source-event-mapping branch July 22, 2024 05:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants