refactor: af user deletion #1735
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anantjain45823
added
DO NOT MERGE
|
Please add proper description with more info about what is this Pr trying to achieve @anantjain45823 |
koladilip
approved these changes
Dec 27, 2022
anantjain45823
changed the base branch from
fix.user-deletion-handlers
to
fix.user-deletion-handlers-v2
anantjain45823
removed
the
DO NOT MERGE
saikumarrs
approved these changes
Jan 5, 2023
saikumarrs
added a commit
that referenced
this pull request
Jan 5, 2023
* fix: make all the destination user deletion handlers uniform * fix: update the metadata fetch code to send to bugsnag * fix: req metadata function in user deletion handler * fix: correction for the MAX_BATCH_SIZE value (#1720) Co-authored-by: Anant <[email protected]> * fix: update to add robust error handling (#1719) * fix: update deletion flows * fix: update test cases * fix: update test cases to remove the ones which require mocking * fix: handled specific success sattus for braze and intercom * fix: make config error for af as retryable * fix: user deletion handlers test cases (#1723) * feat: mock cases for clevertap * feat: mock cases for engage Co-authored-by: Anant <[email protected]> * fix(destination): avoid creating parallel delete user requests in clevertap (#1751) * fix: user deletion module update (#1750) * chore: coverage and testing for mixpanel and engage * fix: updated api and test coverage for intercom * refactor: coverage and testing for sendgrid * feat: Batch Support with testing and mocking for Amplitude * feat: Batch Support with testing and mocking for Braze * fix: conflicts * fix: conflicts+1 * fix: conflicts and resolved comments * fix: added comments * fix: resolved Comments * fix: resolved Conflicts * fix: resolved Comments * fix: resolved Comments+1 * fix: resolved Comments+2 Co-authored-by: Anant <[email protected]> * refactor: af user deletion (#1735) * refactor: af user deletion * fix: conflicts Co-authored-by: Anant <[email protected]> Co-authored-by: Utsab Chowdhury <[email protected]> Co-authored-by: Anant Jain <[email protected]> Co-authored-by: Anant <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review