Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(destination): do not update event properties to lowercase in hubspot #1559

Merged
merged 3 commits into from
Nov 10, 2022
Merged

fix(destination): do not update event properties to lowercase in hubspot #1559

merged 3 commits into from
Nov 10, 2022

Conversation

ItsSudip
Copy link
Member

Description of the change

Inside the getHashFromArray function we are setting properties to lowercase, which is causing mismatch with dashboard properties. So updated the code not to change whatever we are getting in properties.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@ItsSudip ItsSudip requested a review from a team as a code owner November 10, 2022 03:42
@saikumarrs saikumarrs changed the title fix(destination): do not update event properties to lowercase fix(destination): do not update event properties to lowercase in hubspot Nov 10, 2022
@ItsSudip ItsSudip merged commit e41b37f into master Nov 10, 2022
@github-actions github-actions bot mentioned this pull request Nov 10, 2022
Merged
@github-actions github-actions bot deleted the fix.hs_eventProperties branch March 15, 2023 02:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@sauravlal15 sauravlal15 sauravlal15 approved these changes

@anantjain45823 anantjain45823 Awaiting requested review from anantjain45823 anantjain45823 is a code owner automatically assigned from rudderlabs/integrations

@saikumarrs saikumarrs Awaiting requested review from saikumarrs saikumarrs is a code owner automatically assigned from rudderlabs/integrations

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ItsSudip @utsabc @sauravlal15 @saikumarrs