feat: ga user delete support #1531
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o feat.ga-reg-support
|
Are we using a testing framework in transformer? It is risky to implement new features without test coverage. |
We do have a testing framework, we do write test-cases & have scenarios covered by tests |
added 8 commits
November 2, 2022 14:32
…lder) - mock koa context's get method - implement a callback to get the header value
…rlabs/rudder-transformer into feat.ga-reg-support
…o feat.ga-reg-support
Signed-off-by: Sai Sankeerth <[email protected]>
…o feat.ga-reg-support
…o feat.ga-reg-support
…o feat.ga-reg-support
…ansformer into feat.ga-reg-support
sanpj2292
requested review from
a team,
arnab-p and
sivashanmukh
as code owners
krishna2020
reviewed
Nov 15, 2022
added 2 commits
November 15, 2022 18:00
…o feat.ga-reg-support
- update the error message to include actual destination message for normal errors
saikumarrs
previously approved these changes
Nov 16, 2022
saikumarrs
approved these changes
Nov 16, 2022
krishna2020
approved these changes
Nov 16, 2022
…o feat.ga-reg-support
mihir-4116
approved these changes
Nov 18, 2022
added 2 commits
November 22, 2022 10:27
…o feat.ga-reg-support
…o feat.ga-reg-support
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
In this PR, we have included the Regulation API support for Universal Analytics(GA) which uses OAuth for processing the user deletion request
This work would unblock any other destinations that might use OAuth for processing delete user requests
https://www.notion.so/rudderstacks/Integrate-OAuth-in-regulation-worker-module-of-server-dae0cf6ef89e41eb91e9212ac524cf49
Type of change
Related issues
Checklists
Development
Code review