Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(clevertap): correction for the max_batch_size value #1720

Merged
merged 1 commit into from
Dec 20, 2022
Merged

fix(clevertap): correction for the max_batch_size value #1720

merged 1 commit into from
Dec 20, 2022

Conversation

anantjain45823
Copy link
Contributor

@anantjain45823 anantjain45823 commented Dec 20, 2022 •
edited
Loading

Description of the change

While validating the max batch size, that is, batch limit for user deletion for clever tap we found the limit was 100, not 1000. This PR mainly changes the limit number.
We found this number when we were testing for 1000 records it returned us with message "Max 100 are allowed"

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

@anantjain45823 anantjain45823 requested a review from a team as a code owner December 20, 2022 10:30
@anantjain45823 anantjain45823 self-assigned this Dec 20, 2022
utsabc
utsabc approved these changes Dec 20, 2022
View reviewed changes
Copy link
Member

@utsabc utsabc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we add comment why this number

@anantjain45823 anantjain45823 merged commit 9c2abb5 into fix.user-deletion-handlers Dec 20, 2022
saikumarrs added a commit that referenced this pull request Jan 5, 2023
@saikumarrs @utsabc
@anantjain45823 @anantrudder
fix: user deletion handlers implementation across destinations (#1748)
786cfe0 
* fix: make all the destination user deletion handlers uniform

* fix: update the metadata fetch code to send to bugsnag

* fix: req metadata function in user deletion handler

* fix: correction for the MAX_BATCH_SIZE value (#1720)

Co-authored-by: Anant <[email protected]>

* fix: update to add robust error handling (#1719)

* fix: update deletion flows

* fix: update test cases

* fix: update test cases to remove the ones which require mocking

* fix: handled specific success sattus for braze and intercom

* fix: make config error for af as retryable

* fix: user deletion handlers test cases (#1723)

* feat: mock cases for clevertap

* feat: mock cases for engage

Co-authored-by: Anant <[email protected]>

* fix(destination): avoid creating parallel delete user requests in clevertap (#1751)

* fix: user deletion module update (#1750)

* chore: coverage and testing for mixpanel and engage

* fix: updated api and test coverage for intercom

* refactor: coverage and testing for sendgrid

* feat: Batch Support with testing and mocking for Amplitude

* feat: Batch Support with testing and mocking for Braze

* fix: conflicts

* fix: conflicts+1

* fix: conflicts and resolved comments

* fix: added comments

* fix: resolved Comments

* fix: resolved Conflicts

* fix: resolved Comments

* fix: resolved Comments+1

* fix: resolved Comments+2

Co-authored-by: Anant <[email protected]>

* refactor: af user deletion (#1735)

* refactor: af user deletion

* fix: conflicts

Co-authored-by: Anant <[email protected]>

Co-authored-by: Utsab Chowdhury <[email protected]>
Co-authored-by: Anant Jain <[email protected]>
Co-authored-by: Anant <[email protected]>
@github-actions github-actions bot deleted the fix.user-deletion-handlers-update3 branch March 21, 2023 02:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@koladilip koladilip Awaiting requested review from koladilip

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees

@anantjain45823 anantjain45823

Labels
Ready for Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@anantjain45823 @utsabc @saikumarrs @anantrudder