feat: move deleteusers tests to a separate file #1551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- implement general axios mock client - test of the general mock axios client - implement unit tests using the general mock axios client - new way of defining the http responses
sanpj2292
requested review from
yashasvibajpai,
sandeepdsvs and
a team
and removed request for
a team
krishna2020
reviewed
Nov 7, 2022
…ansformer into feat.ga-reg-support-axios-tests
sanpj2292
added
enhancement
krishna2020
reviewed
Nov 8, 2022
saikumarrs
reviewed
Nov 8, 2022
krishna2020
reviewed
Nov 9, 2022
added 3 commits
November 10, 2022 07:37
…ansformer into feat.ga-reg-support-axios-tests
…ansformer into feat.ga-reg-support-axios-tests
saikumarrs
approved these changes
Nov 14, 2022
koladilip
approved these changes
Nov 14, 2022
krishna2020
reviewed
Nov 14, 2022
krishna2020
approved these changes
Nov 14, 2022
krishna2020
pushed a commit
that referenced
this pull request
Nov 24, 2022
* feat�: regulation api support for universal analytics initial commit * modify deleteUsers api to include errorCategory, auth to send delete req to UA * - correctly getting status code while error is thrown (using ErrorBuilder) - mock koa context's get method - implement a callback to get the header value * adding secret validation * remove unnecessary code * add first successful test-case for ga delete support Signed-off-by: Sai Sankeerth <[email protected]> * remove comment * rename variable * new convention of parsing responses * feat: move deleteusers tests to a separate file (#1551) * extending common validations functions in all delete users supported destinations * add test-case for erreneous scenario in a deleteUser request - update the error message to include actual destination message for normal errors * support for exclusion of destination for troubleshooting Signed-off-by: Sai Sankeerth <[email protected]> Co-authored-by: Sai Sankeerth <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
The intention through this PR is to move the
deleteUserstests to a different file rather than have it inproxytests. In the same way, it is seen that we have different responses andaxiosis being used in different ways. To mock all of them in a generic we have implemented a generic axios mock client through whichdeleteUserstest-cases are being executedNote: This generic axios mock client is being currently used by only
GA. All other destinations(fordeleteUsers) are using the earlier mock client(mockedAxiosClient)In brief the changes are:
Type of change
Related issues
Checklists
Development
Code review