fix(active-campaign): add check before iterating stored event array (#…

…1902) * fix: add check before iterating stored event array * chore: address comment --------- Co-authored-by: Utsab Chowdhury <[email protected]> Co-authored-by: ItsSudip <[email protected]>
rudderlabs · Feb 28, 2023 · 9666e85 · 9666e85
1 parent 8638ee7
commit 9666e85
Showing 1 changed file with 6 additions and 12 deletions.
diff --git a/src/v0/destinations/active_campaign/transform.js b/src/v0/destinations/active_campaign/transform.js
@@ -425,14 +425,11 @@ const screenRequestHandler = async (message, category, destination) => {
     );
   }
 
-  const storedEventsArr = res.response.data.eventTrackingEvents;
-  const storedEvents = [];
-  storedEventsArr.map((ev) => {
-    storedEvents.push(ev.name);
-  });
+  const storedEventsArr = res.response?.data?.eventTrackingEvents;
+  const events = Array.isArray(storedEventsArr) ? storedEventsArr.map((ev) => ev.name) : [];
   // Check if the source event is already present if not we make a create request
   // Ref - https://developers.activecampaign.com/reference/create-a-new-event-name-only
-  if (!storedEvents.includes(message.event)) {
+  if (!events.includes(message.event)) {
     // Create the event
     endpoint = `${destination.Config.apiUrl}${category.getEventEndPoint}`;
     const requestData = {
@@ -503,14 +500,11 @@ const trackRequestHandler = async (message, category, destination) => {
     );
   }
 
-  const storedEventsArr = res.response.data.eventTrackingEvents;
-  const storedEvents = [];
-  storedEventsArr.map((ev) => {
-    storedEvents.push(ev.name);
-  });
+  const storedEventsArr = res.response?.data?.eventTrackingEvents;
+  const events = Array.isArray(storedEventsArr) ? storedEventsArr.map((ev) => ev.name) : [];
   // Check if the source event is already present if not we make a create request
   // Ref - https://developers.activecampaign.com/reference/create-a-new-event-name-only
-  if (!storedEvents.includes(message.event)) {
+  if (!events.includes(message.event)) {
     // Create the event
     endpoint = `${destination.Config.apiUrl}${category.getEventEndPoint}`;
     const requestData = {