fix: cartToken fetching from input event

rudderlabs · Aug 5, 2024 · 9181179 · 9181179
1 parent 96a23b2
commit 9181179
Show file tree

Hide file tree

Showing 2 changed files with 3 additions and 5 deletions.
diff --git a/src/util/prometheus.js b/src/util/prometheus.js
@@ -431,7 +431,7 @@ class Prometheus {
         name: 'shopify_redis_no_val',
         help: 'shopify_redis_no_val',
         type: 'counter',
-        labelNames: ['writeKey', 'source'],
+        labelNames: ['writeKey', 'source', 'event'],
       },
       {
         name: 'invalid_shopify_event',

diff --git a/src/v0/sources/shopify/transform.js b/src/v0/sources/shopify/transform.js
@@ -213,10 +213,8 @@ const isIdentifierEvent = (event) =>
   ['rudderIdentifier', 'rudderSessionIdentifier'].includes(event?.event);
 const processIdentifierEvent = async (event, metricMetadata) => {
   if (useRedisDatabase) {
-    let { cartToken } = event;
-    if (typeof cartToken === 'string') {
-      [cartToken] = cartToken.split('?');
-    }
+    const cartToken =
+      typeof event.cartToken === 'string' ? event.cartToken.split('?')[0] : event.cartToken;
     logger.info(`{{SHOPIFY::}} writeKey: ${metricMetadata.writeKey}, cartToken: ${cartToken}`, {
       type: 'set',
       source: metricMetadata.source,