Skip to content

Commit

Permalink
fix: use correct endpoint for custom events (#3954)
Browse files Browse the repository at this point in the history
* fix: use correct endpoint for custom events

* fix: sonar cloud issue
ItsSudip authored Jan 3, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
1 parent 0dedaa2 commit 49eb591
Showing 3 changed files with 10 additions and 11 deletions.
1 change: 1 addition & 0 deletions src/v0/destinations/branch/data/eventMapping.js
Original file line number Diff line number Diff line change
@@ -40,6 +40,7 @@ const CommerceEventConfig = {
'Spend Credits': 'SPEND_CREDITS',
'Promotion Viewed': 'VIEW_AD',
'Promotion Clicked': 'CLICK_AD',
Purchase: 'PURCHASE',
Reserve: 'RESERVE',
},
event_data: ['transaction_id', 'currency', 'revenue', 'shipping', 'tax', 'coupon', 'description'],
16 changes: 7 additions & 9 deletions src/v0/destinations/branch/transform.js
Original file line number Diff line number Diff line change
@@ -46,17 +46,16 @@ function getCategoryAndName(rudderEventName) {
let requiredName = null;
let requiredCategory = null;
// eslint-disable-next-line array-callback-return, sonarjs/no-ignored-return
Object.keys(category.name).find((branchKey) => {
Object.keys(category.name).forEach((branchKey) => {
if (
typeof branchKey === 'string' &&
typeof rudderEventName === 'string' &&
branchKey.toLowerCase() === rudderEventName.toLowerCase()
(branchKey.toLowerCase() === rudderEventName.toLowerCase() ||
category.name[branchKey].toLowerCase() === rudderEventName.toLowerCase())
) {
requiredName = category.name[branchKey];
requiredCategory = category;
return true;
}
return false;
});
if (requiredName != null && requiredCategory != null) {
return { evName: requiredName, category: requiredCategory };
@@ -116,14 +115,12 @@ function mapPayload(category, rudderProperty, rudderPropertiesObj) {
let valFound = false;
if (category.content_items) {
// eslint-disable-next-line sonarjs/no-ignored-return
Object.keys(category.content_items).find((branchMappingProperty) => {
Object.keys(category.content_items).forEach((branchMappingProperty) => {
if (branchMappingProperty === rudderProperty) {
const tmpKeyName = category.content_items[branchMappingProperty];
contentItems[tmpKeyName] = rudderPropertiesObj[rudderProperty];
valFound = true;
return true;
}
return false;
});
}

@@ -217,16 +214,17 @@ function getCommonPayload(message, category, evName) {
function processMessage(message, destination) {
let evName;
let category;
let updatedEventName = message.event;
switch (message.type) {
case EventType.TRACK: {
if (!message.event) {
throw new InstrumentationError('Event name is required');
}
({ evName, category } = getCategoryAndName(message.event));
const eventNameFromConfig = getMappedEventNameFromConfig(message, destination);
if (eventNameFromConfig) {
evName = eventNameFromConfig;
updatedEventName = eventNameFromConfig;
}
({ evName, category } = getCategoryAndName(updatedEventName));
break;
}
case EventType.IDENTIFY:
4 changes: 2 additions & 2 deletions test/integrations/destinations/branch/processor/data.ts
Original file line number Diff line number Diff line change
@@ -1505,7 +1505,7 @@ export const data = [
branchKey: 'test_branch_key',
eventsMapping: [
{
from: 'Order Completed',
from: 'Some Random Event',
to: 'PURCHASE',
},
],
@@ -1561,7 +1561,7 @@ export const data = [
userAgent:
'Mozilla/5.0 (Macintosh; Intel Mac OS X 10_15_2) AppleWebKit/537.36 (KHTML, like Gecko) Chrome/79.0.3945.88 Safari/537.36',
},
event: 'Order Completed',
event: 'Some Random Event',
integrations: {
All: true,
},

0 comments on commit 49eb591

Please sign in to comment.