Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: async framework destination live events #5480

Merged
merged 2 commits into from
Feb 10, 2025

Conversation

achettyiitr
Copy link
Member

Description

  • Async destination debugger currently handles only failed and succeeded state, In the case of importing state, it is getting translated to failed status.

Linear Ticket

  • Resolves PIPE-1880

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Feb 5, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 75.00%. Comparing base (c6e0225) to head (1b11fc4).
Report is 3 commits behind head on release/1.42.x.

Additional details and impacted files
@@                Coverage Diff                 @@
##           release/1.42.x    #5480      +/-   ##
==================================================
+ Coverage           74.86%   75.00%   +0.13%     
==================================================
  Files                 458      458              
  Lines               63260    63269       +9     
==================================================
+ Hits                47360    47454      +94     
+ Misses              13242    13169      -73     
+ Partials             2658     2646      -12     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the fix.async-framework-debugger branch from 7d6ae36 to 4fd5ec3 Compare February 6, 2025 05:18
@achettyiitr achettyiitr requested a review from koladilip February 6, 2025 05:21
@achettyiitr achettyiitr changed the title fix: async framework destination debugger fix: async framework destination live events Feb 6, 2025
Copy link
Contributor

@mihir20 mihir20 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@achettyiitr achettyiitr merged commit 40d9c7d into release/1.42.x Feb 10, 2025
58 checks passed
@achettyiitr achettyiitr deleted the fix.async-framework-debugger branch February 10, 2025 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants