feat: rs load using folder #5450
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
achettyiitr
force-pushed
the
feat.rs-load-using-folder
branch
from
bb73472 to
8db83dd
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #5450 +/- ##
==========================================
- Coverage 74.84% 74.78% -0.07%
==========================================
Files 440 440
Lines 61425 61490 +65
==========================================
+ Hits 45974 45985 +11
- Misses 12916 12966 +50
- Partials 2535 2539 +4 ☔ View full report in Codecov by Sentry. |
achettyiitr
commented
Jan 22, 2025
| }, | ||
| { | ||
| name: "with IAM Role", |
There was a problem hiding this comment.
There is no point in running separate test for password vs Iam role. We already have covered these test above.
achettyiitr
force-pushed
the
feat.rs-load-using-folder
branch
from
8db83dd to
35ab77d
Compare
RanjeetMishra
approved these changes
Jan 24, 2025
shekhar-rudder
approved these changes
Jan 24, 2025
achettyiitr
force-pushed
the
feat.rs-load-using-folder
branch
from
35ab77d to
6123e58
Compare
achettyiitr
force-pushed
the
feat.rs-load-using-folder
branch
from
6123e58 to
c10b877
Compare
|
|
||
| s3Location, region = warehouseutils.GetS3Location(objectLocation) | ||
| if region == "" { | ||
| region = "us-east-1" |
There was a problem hiding this comment.
Can we declare us-east-1 as a constant and use it here ? Or maybe encapsulate this logic inside warehouseutils.GetS3Location ?
This was referenced Feb 4, 2025
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
loadByFolderPathconfiguration, by default it's false.Linear Ticket
Security