Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add validation library to be compatible with ingestion svc [PIPE-1834] #5408

Closed
wants to merge 4 commits into from

Conversation

BonapartePC
Copy link
Contributor

Description

add validation library to be compatible with ingestion svc

Linear Ticket

https://linear.app/rudderstack/issue/PIPE-1834/gateway-validation-library

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 5, 2025

Codecov Report

Attention: Patch coverage is 75.00000% with 6 lines in your changes missing coverage. Please review.

Project coverage is 74.82%. Comparing base (78fb917) to head (400b824).
Report is 13 commits behind head on master.

Files with missing lines Patch % Lines
gateway/validation/validation.go 68.42% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5408      +/-   ##
==========================================
+ Coverage   74.76%   74.82%   +0.05%     
==========================================
  Files         438      441       +3     
  Lines       61339    61453     +114     
==========================================
+ Hits        45862    45984     +122     
+ Misses      12935    12929       -6     
+ Partials     2542     2540       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@BonapartePC BonapartePC requested a review from fracasula January 6, 2025 09:18
@ktgowtham
Copy link
Contributor

@mihir20 @fracasula , closing this PR as discussed.

@ktgowtham ktgowtham closed this Jan 9, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants