Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: bq load using folder #5445

Merged
merged 3 commits into from
Jan 28, 2025
Merged

feat: bq load using folder #5445

merged 3 commits into from
Jan 28, 2025

Conversation

achettyiitr
Copy link
Member

@achettyiitr achettyiitr commented Jan 20, 2025

Description

  • BQ load using folder pattern instead of providing all file locations.
  • Added loadByFolderPath configuration, by default it's false.

Linear Ticket

  • Resolves WAR-179, WAR-216

Security

  • The code changed/added as part of this pull request won't create any security issues with how the software is being used.

Copy link

codecov bot commented Jan 20, 2025

Codecov Report

Attention: Patch coverage is 73.58491% with 14 lines in your changes missing coverage. Please review.

Project coverage is 74.91%. Comparing base (71efda1) to head (baa9bbb).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
warehouse/integrations/bigquery/bigquery.go 70.21% 9 Missing and 5 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #5445      +/-   ##
==========================================
+ Coverage   74.84%   74.91%   +0.06%     
==========================================
  Files         440      440              
  Lines       61425    61430       +5     
==========================================
+ Hits        45974    46020      +46     
+ Misses      12916    12889      -27     
+ Partials     2535     2521      -14     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@achettyiitr achettyiitr force-pushed the feat.bq-load-using-folder branch 3 times, most recently from b4c2714 to 32493ed Compare January 21, 2025 20:39
warehouse/integrations/bigquery/bigquery.go Show resolved Hide resolved
warehouse/integrations/bigquery/bigquery.go Outdated Show resolved Hide resolved
warehouse/integrations/bigquery/bigquery.go Outdated Show resolved Hide resolved
warehouse/integrations/bigquery/bigquery_test.go Outdated Show resolved Hide resolved
@shekhar-rudder shekhar-rudder mentioned this pull request Jan 27, 2025
1 task
@achettyiitr achettyiitr merged commit 9c733be into master Jan 28, 2025
58 checks passed
@achettyiitr achettyiitr deleted the feat.bq-load-using-folder branch January 28, 2025 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants