Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(new integration): onboarding june device mode destination v1.1 #673

Merged
merged 7 commits into from
Oct 11, 2022

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Sep 30, 2022

Description of the change

Onboarding June device mode destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@github-actions
Copy link

github-actions bot commented Sep 30, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 38.41 KB (+0.17% 🔺) 769 ms (+0.17% 🔺) 397 ms (-25.98% 🔽) 1.2 s
All Integrations - CDN 1 MB (+2.52% 🔺) 20.6 s (+2.52% 🔺) 4.1 s (-23.44% 🔽) 24.7 s
Core - NPM 38.62 KB (+0.14% 🔺) 773 ms (+0.14% 🔺) 530 ms (+19.54% 🔺) 1.4 s

Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In order for logger module to work add the below code in browser.js.

  1. Add analytics in the constructor
    constructor(config, analytics) {
  2. Add the below code in the constructor.
    if (analytics.logLevel) { logger.setLogLevel(analytics.logLevel); }

@Gauravudia
Copy link
Contributor Author

In order for logger module to work add the below code in browser.js.

  1. Add analytics in the constructor
    constructor(config, analytics) {
  2. Add the below code in the constructor.
    if (analytics.logLevel) { logger.setLogLevel(analytics.logLevel); }

Updated in production-staging. Do I need to update these changes in v1-staging also??

@saikumarrs
Copy link
Member

In order for logger module to work add the below code in browser.js.

  1. Add analytics in the constructor
    constructor(config, analytics) {
  2. Add the below code in the constructor.
    if (analytics.logLevel) { logger.setLogLevel(analytics.logLevel); }

Updated in production-staging. Do I need to update these changes in v1-staging also??

It's better to address this in the v1-staging branch and let them automatically flow into v1.1 branches.

@Gauravudia
Copy link
Contributor Author

In order for logger module to work add the below code in browser.js.

  1. Add analytics in the constructor
    constructor(config, analytics) {
  2. Add the below code in the constructor.
    if (analytics.logLevel) { logger.setLogLevel(analytics.logLevel); }

Updated in production-staging. Do I need to update these changes in v1-staging also??

It's better to address this in the v1-staging branch and let them automatically flow into v1.1 branches.

raised the PR for v1-staging
#675 (review)

shrouti1507
shrouti1507 previously approved these changes Oct 5, 2022
@Gauravudia Gauravudia merged commit 1cb56f0 into production-staging Oct 11, 2022
@Gauravudia Gauravudia deleted the feature/june branch October 11, 2022 05:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants