Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(quora pixel): add data-loader attribute #649

Merged
merged 5 commits into from
Sep 13, 2022
Merged

feat(quora pixel): add data-loader attribute #649

merged 5 commits into from
Sep 13, 2022

Conversation

Gauravudia
Copy link
Contributor

@Gauravudia Gauravudia commented Sep 13, 2022 •
edited by SumanthPuram
Loading

Description of the change

Added data loader attribute for Quora Pixel device mode destination

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@Gauravudia Gauravudia self-assigned this Sep 13, 2022
@Gauravudia Gauravudia added the Ready for review Changes are ready to be reviewed label Sep 13, 2022
@Gauravudia Gauravudia changed the title chora(quora pixel): added data-loader attribute chore(quora pixel): added data-loader attribute Sep 13, 2022
@saikumarrs saikumarrs changed the title chore(quora pixel): added data-loader attribute feat(quora pixel): add data-loader attribute Sep 13, 2022
@Gauravudia Gauravudia merged commit 1b23d4c into v1-staging Sep 13, 2022
@Gauravudia Gauravudia deleted the feature/quoraPixel branch September 13, 2022 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@utsabc utsabc utsabc approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

Assignees

@Gauravudia Gauravudia

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Gauravudia @utsabc @saikumarrs