Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature(new integration): Shynet device mode onboarding v1.1 #641

Merged
merged 3 commits into from
Sep 7, 2022

Conversation

aashishmalik
Copy link
Contributor

@aashishmalik aashishmalik commented Sep 7, 2022

Description of the change

Shynet Destination .

Description here

Type of change

  • New feature (non-breaking change that adds functionality)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@utsabc
Copy link
Member

utsabc commented Sep 7, 2022

Take a pull from production once I see some extra changes apart from shynet here

@aashishmalik aashishmalik changed the base branch from production to production-staging September 7, 2022 07:10
@MoumitaM MoumitaM changed the title Feat/shynet prod Feature(new integration): Shynet device mode onboarding v1.1 Sep 7, 2022
MoumitaM
MoumitaM previously approved these changes Sep 7, 2022
@github-actions
Copy link

github-actions bot commented Sep 7, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 37.3 KB (+0.14% 🔺) 746 ms (+0.14% 🔺) 532 ms (-31.32% 🔽) 1.3 s
All Integrations - CDN 838.81 KB (+2.28% 🔺) 16.8 s (+2.28% 🔺) 4.1 s (-5.71% 🔽) 20.9 s
Core - NPM 37.52 KB (+0.22% 🔺) 751 ms (+0.22% 🔺) 674 ms (+3.98% 🔺) 1.5 s

@utsabc utsabc merged commit 2e7fbd6 into production-staging Sep 7, 2022
@utsabc utsabc deleted the feat/ShynetProd branch September 7, 2022 07:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants