Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat (core): user session #637

Merged
merged 32 commits into from
Sep 20, 2022
Merged

feat (core): user session #637

merged 32 commits into from
Sep 20, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Sep 5, 2022 •
edited by SumanthPuram
Loading

Description of the change

Description of the change can be found here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner September 5, 2022 06:55
@saikumarrs
Copy link
Member

Please change the PR title to conventional commits format.

@MoumitaM MoumitaM changed the title Feature: User session implementation(v1) feat: user session Sep 5, 2022
saikumarrs
saikumarrs requested changes Sep 5, 2022
View reviewed changes
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs changed the title feat: user session feat (core): user session Sep 6, 2022
@MoumitaM MoumitaM requested a review from saikumarrs September 6, 2022 10:11
saikumarrs
saikumarrs requested changes Sep 6, 2022
View reviewed changes
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs September 6, 2022 15:17
saikumarrs
saikumarrs previously approved these changes Sep 7, 2022
View reviewed changes
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@MoumitaM MoumitaM requested a review from saikumarrs September 7, 2022 08:42
@MoumitaM MoumitaM self-assigned this Sep 7, 2022
@MoumitaM MoumitaM requested a review from saikumarrs September 7, 2022 12:42
saikumarrs
saikumarrs previously approved these changes Sep 7, 2022
View reviewed changes
@MoumitaM MoumitaM requested a review from saikumarrs September 19, 2022 06:48
saikumarrs
saikumarrs requested changes Sep 19, 2022
View reviewed changes
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
session/index.js Outdated Show resolved Hide resolved
utils/utils.js Outdated Show resolved Hide resolved
MoumitaM and others added 4 commits September 19, 2022 17:52
@MoumitaM @saikumarrs
Update session/index.js
efa45d0 
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM @saikumarrs
Update session/index.js
a41919d 
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM @saikumarrs
Update session/index.js
cfd5c85 
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM
refactor: user session
ddb5529
@MoumitaM MoumitaM requested a review from saikumarrs September 19, 2022 14:32
@MoumitaM MoumitaM requested a review from saikumarrs September 20, 2022 05:21
@MoumitaM MoumitaM requested a review from saikumarrs September 20, 2022 06:06
saikumarrs
saikumarrs reviewed Sep 20, 2022
View reviewed changes
session/index.js Outdated Show resolved Hide resolved
@MoumitaM @saikumarrs
Update session/index.js
e455a5e 
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM MoumitaM requested a review from saikumarrs September 20, 2022 06:11
@MoumitaM MoumitaM merged commit 23ce782 into v1-staging Sep 20, 2022
@MoumitaM MoumitaM deleted the feature/user-session-v1 branch September 20, 2022 06:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pallabmaiti pallabmaiti pallabmaiti left review comments

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees

@MoumitaM MoumitaM

Labels
beta testing in progress DO NOT MERGE
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoumitaM @saikumarrs @pallabmaiti