Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enhancement(Integration): Pinterest Tag event_id added for deduplication + custom event support #635

Merged
merged 4 commits into from
Sep 5, 2022
Merged

Enhancement(Integration): Pinterest Tag event_id added for deduplication + custom event support #635

merged 4 commits into from
Sep 5, 2022

Conversation

shrouti1507
Copy link
Contributor

@shrouti1507 shrouti1507 commented Aug 31, 2022 •
edited
Loading

Adding deduplication support for pinterest_tag
Ref: https://view.highspot.com/viewer/629a4a9284742fae381c6804
Also, adding "custom" event support, if event sent by the user doesn't match the internal mapping or event mapping in webapp.

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@shrouti1507 shrouti1507 added the enhancement New feature or request label Aug 31, 2022
@shrouti1507 shrouti1507 requested a review from MoumitaM August 31, 2022 15:46
@shrouti1507 shrouti1507 self-assigned this Aug 31, 2022
utsabc
utsabc previously approved these changes Sep 4, 2022
View reviewed changes
@shrouti1507 shrouti1507 requested a review from utsabc September 5, 2022 04:23
@utsabc utsabc merged commit 4e0f2f8 into v1-staging Sep 5, 2022
@utsabc utsabc deleted the feature/pinterest-tag-eventId branch September 5, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

Assignees

@shrouti1507 shrouti1507

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@shrouti1507 @utsabc @MoumitaM