Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(new integration): LiveChat web Device mode integration onboarding #633

Merged
merged 9 commits into from
Sep 6, 2022
Merged

feature(new integration): LiveChat web Device mode integration onboarding #633

merged 9 commits into from
Sep 6, 2022

Conversation

RohitKhatta
Copy link
Contributor

@RohitKhatta RohitKhatta commented Aug 31, 2022 •
edited by SumanthPuram
Loading

Description of the change

onboarding LiveChat

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@RohitKhatta RohitKhatta self-assigned this Aug 31, 2022
shrouti1507
shrouti1507 previously approved these changes Sep 2, 2022
View reviewed changes
integrations/LiveChat/browser.js Outdated Show resolved Hide resolved
integrations/LiveChat/browser.js Show resolved Hide resolved
@shrouti1507 shrouti1507 self-requested a review September 2, 2022 05:10
@shrouti1507 shrouti1507 dismissed their stale review September 2, 2022 05:12

Approval was done by mistake. More work left in this branch.

@shrouti1507 shrouti1507 requested a review from MoumitaM September 6, 2022 04:12
@utsabc utsabc merged commit b018b87 into v1-staging Sep 6, 2022
@utsabc utsabc deleted the feature/livechatIntegration branch September 6, 2022 06:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shrouti1507 shrouti1507 shrouti1507 approved these changes

@MoumitaM MoumitaM MoumitaM approved these changes

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

@mihir-4116 mihir-4116 Awaiting requested review from mihir-4116

Assignees

@RohitKhatta RohitKhatta

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@RohitKhatta @utsabc @MoumitaM @shrouti1507