Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bugfix(non CFD): SnapEngage - adding name field in constructor #632

Merged
merged 2 commits into from
Aug 30, 2022
Merged

bugfix(non CFD): SnapEngage - adding name field in constructor #632

merged 2 commits into from
Aug 30, 2022

Conversation

rohithkaza
Copy link
Contributor

@rohithkaza rohithkaza commented Aug 30, 2022 •
edited by SumanthPuram
Loading

Description of the change

Adding name field in the constructor

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@rohithkaza rohithkaza requested a review from utsabc as a code owner August 30, 2022 12:08
@rohithkaza rohithkaza self-assigned this Aug 30, 2022
@rohithkaza rohithkaza requested a review from saikumarrs as a code owner August 30, 2022 12:08
MoumitaM
MoumitaM requested changes Aug 30, 2022
View reviewed changes
Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You need to import the NAME from constants file

@rohithkaza rohithkaza requested review from utsabc and MoumitaM August 30, 2022 12:13
@rohithkaza rohithkaza merged commit 59af25b into v1-staging Aug 30, 2022
@rohithkaza rohithkaza deleted the bugfix/snapengage branch August 30, 2022 12:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

@shrouti1507 shrouti1507 Awaiting requested review from shrouti1507

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

@saikumarrs saikumarrs Awaiting requested review from saikumarrs

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@rohithkaza rohithkaza

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rohithkaza @utsabc @MoumitaM