Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(build): update filesize rollup plugin options #603

Merged
merged 1 commit into from
Aug 5, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Aug 5, 2022

Description of the change

Added an option to filesize rollup plugin, which will help compare the size of the output b/w the previous and current build runs. Also, added another option to show the size of Brotli compressed SDK.
This will be helpful during development.

Example output:

analytics.js → dist/rudder-analytics.min.js...
┌─────────────────────────────────────────────────────────────┐
│                                                             │
│   Destination: dist/rudder-analytics.min.js                 │
│   Bundle Size:  115.14 KB (was 115.58 KB in last build)     │
│   Minified Size:  114.58 KB (was 114.97 KB in last build)   │
│   Gzipped Size:  36.95 KB (was 37.2 KB in last build)       │
|   Brotli size: 30.27 KB (was 31.87 KB in last build)        |
│                                                             │
└─────────────────────────────────────────────────────────────┘

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs requested a review from MoumitaM as a code owner August 5, 2022 10:57
@saikumarrs saikumarrs self-assigned this Aug 5, 2022
@github-actions
Copy link

github-actions bot commented Aug 5, 2022

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.93 KB (0%) 739 ms (0%) 753 ms (-21.92% 🔽) 1.5 s
All Integrations - CDN 666.75 KB (0%) 13.4 s (0%) 3.6 s (-8.79% 🔽) 17 s
Core - NPM 37.14 KB (0%) 743 ms (0%) 640 ms (-9.32% 🔽) 1.4 s

@saikumarrs saikumarrs merged commit 57fa6c3 into production-staging Aug 5, 2022
@saikumarrs saikumarrs deleted the chore/filesize-rollup branch August 5, 2022 11:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants