Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: dataset attribute syntax updated in scriptLoader #598

Merged
merged 2 commits into from
Aug 4, 2022
Merged

Fix: dataset attribute syntax updated in scriptLoader #598

merged 2 commits into from
Aug 4, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Aug 4, 2022 •
edited by SumanthPuram
Loading

Description of the change

Dataset attribute syntax updated in scriptLoader as the previous syntax was not working in IE 10.

From element.dataset.property=propertyValue to element.setAttribute("data-property","propertyValue").

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

saikumarrs
saikumarrs requested changes Aug 4, 2022
View reviewed changes
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update all the integration modules with this change.

@MoumitaM MoumitaM requested a review from saikumarrs August 4, 2022 06:29
@saikumarrs saikumarrs merged commit 9e0ca2b into v1-staging Aug 4, 2022
@saikumarrs saikumarrs deleted the fix/dataset-IE-10 branch August 4, 2022 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@utsabc utsabc Awaiting requested review from utsabc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs