Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature(event filtering): criteo onetag #595

Merged
merged 7 commits into from
Aug 4, 2022
Merged

feature(event filtering): criteo onetag #595

merged 7 commits into from
Aug 4, 2022

Conversation

mihir-4116
Copy link
Contributor

@mihir-4116 mihir-4116 commented Aug 3, 2022 •
edited
Loading

Description of the change

  • in browser.js file of criteo destination, in track call, logic added in order to map events

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@mihir-4116 mihir-4116 added enhancement New feature or request Ready for review Changes are ready to be reviewed labels Aug 3, 2022
@mihir-4116 mihir-4116 self-assigned this Aug 3, 2022
ItsSudip
ItsSudip previously approved these changes Aug 3, 2022
View reviewed changes
saikumarrs
saikumarrs reviewed Aug 4, 2022
View reviewed changes
integrations/Criteo/browser.js Outdated Show resolved Hide resolved
integrations/utils/commonUtils.js Outdated Show resolved Hide resolved
@ItsSudip ItsSudip requested a review from saikumarrs August 4, 2022 12:37
@ItsSudip ItsSudip merged commit c3b05b5 into v1-staging Aug 4, 2022
@ItsSudip ItsSudip deleted the featurecriteo branch August 4, 2022 15:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@ItsSudip ItsSudip ItsSudip approved these changes

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@mihir-4116 mihir-4116

Labels
enhancement New feature or request Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mihir-4116 @ItsSudip @saikumarrs