Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor bug fix in integrationSDKLoaded fn #583

Merged

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Jul 25, 2022

Description of the change

Minor bug fix in integrationSDKLoaded fn

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner July 25, 2022 15:15
@MoumitaM MoumitaM self-assigned this Jul 25, 2022
@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.63 KB (+0.02% 🔺) 733 ms (+0.02% 🔺) 123 ms (+21.19% 🔺) 855 ms
All Integrations - CDN 664.16 KB (0%) 13.3 s (0%) 649 ms (-0.28% 🔽) 14 s
Core - NPM 36.81 KB (+0.02% 🔺) 737 ms (+0.02% 🔺) 123 ms (+44.36% 🔺) 859 ms

@saikumarrs saikumarrs merged commit c17a6e1 into production-staging Jul 26, 2022
@saikumarrs saikumarrs deleted the fix/err-handling-integrationSDKLoaded branch July 26, 2022 06:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants