Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: source config fetch error handled #582

Merged
merged 3 commits into from
Jul 29, 2022
Merged

Fix: source config fetch error handled #582

merged 3 commits into from
Jul 29, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Jul 25, 2022 •
edited by SumanthPuram
Loading

Description of the change

Added error handling in case of source config fetch fails or returns an empty/no response.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner July 25, 2022 15:13
saikumarrs
saikumarrs reviewed Jul 26, 2022
View reviewed changes
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs July 29, 2022 09:55
@saikumarrs saikumarrs merged commit 5edc1c4 into v1-staging Jul 29, 2022
@saikumarrs saikumarrs deleted the fix/no-response branch July 29, 2022 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs