Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor: eslint fixes #578

Merged
merged 14 commits into from
Aug 26, 2022
Merged

refactor: eslint fixes #578

merged 14 commits into from
Aug 26, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Jul 23, 2022 •
edited
Loading

Description of the change

  • eslint auto-fixes
  • Also, some eslint suggestions were incorporated.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs self-assigned this Jul 23, 2022
@saikumarrs saikumarrs changed the base branch from production to production-staging July 23, 2022 18:39
@github-actions
Copy link

github-actions bot commented Jul 23, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 37.16 KB (+0.07% 🔺) 744 ms (+0.07% 🔺) 193 ms (-24.47% 🔽) 936 ms
All Integrations - CDN 759.64 KB (+0.03% 🔺) 15.2 s (+0.03% 🔺) 1.3 s (+4.62% 🔺) 16.5 s
Core - NPM 37.38 KB (+0.08% 🔺) 748 ms (+0.08% 🔺) 214 ms (+44.07% 🔺) 962 ms

@saikumarrs saikumarrs marked this pull request as ready for review July 23, 2022 19:23
MoumitaM
MoumitaM reviewed Jul 24, 2022
View reviewed changes
integrations/Clevertap/browser.js Outdated Show resolved Hide resolved
integrations/Qualtrics/browser.js Outdated Show resolved Hide resolved
utils/xhrModule.js Show resolved Hide resolved
@saikumarrs saikumarrs requested a review from MoumitaM August 11, 2022 14:42
@saikumarrs saikumarrs changed the title Patch: eslint fixes refactor: eslint fixes Aug 11, 2022
MoumitaM
MoumitaM requested changes Aug 11, 2022
View reviewed changes
utils/beaconQueue.js Outdated Show resolved Hide resolved
utils/linker/crc32.js Outdated Show resolved Hide resolved
integrations/VWO/browser.js Outdated Show resolved Hide resolved
integrations/Posthog/browser.js Outdated Show resolved Hide resolved
integrations/Qualtrics/browser.js Outdated Show resolved Hide resolved
integrations/SnapPixel/browser.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM self-requested a review August 11, 2022 15:48
MoumitaM
MoumitaM reviewed Aug 11, 2022
View reviewed changes
Copy link
Contributor

@MoumitaM MoumitaM left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please address the comment in xhrModule.js file

@saikumarrs saikumarrs merged commit fbc3660 into production-staging Aug 26, 2022
@saikumarrs saikumarrs deleted the patch/eslint-fixes branch August 26, 2022 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

@utsabc utsabc Awaiting requested review from utsabc

Assignees

@saikumarrs saikumarrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikumarrs @MoumitaM