Fix a bug in INTERCOM browser.js #572
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This boolean evaluation creates an absurd scenario where the intercom companies array is sent completely empty:
"companies":[{}]
Fixing this boolean evaluation solves the issue and populates the company correctly.
utsabc
approved these changes
Jul 24, 2022
|
@saikumarrs Any update on the approval? it is a critical bug that affects our experience with rudderstack and interocm |
MoumitaM
approved these changes
Jul 27, 2022
|
@ariel-talent-fabric As a next step, please sign the CLA using this form. |
saikumarrs
pushed a commit
that referenced
this pull request
Jul 28, 2022
* Fix a bug in INTERCOM browser.js
This boolean evaluation creates an absurd scenario where the intercom companies array is sent completely empty:
"companies":[{}]
Fixing this boolean evaluation solves the issue and populates the company correctly.
* Update browser.js
Co-authored-by: shrouti1507 <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This boolean evaluation creates an absurd scenario where the intercom companies array is sent completely empty like so:
"companies":[{}]
This fails the intercom "ping" API on an error validation:
Description of the change
The change is just changing the hasOwnProperty inside the if statement to includes
Fixing this boolean evaluation solves the issue and populates the company correctly.
Type of change
Related issues
Checklists
Development
Code review
This change is