Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fb pixel dest #57

Merged
merged 20 commits into from
May 12, 2020
Merged

Fb pixel dest #57

merged 20 commits into from
May 12, 2020

Conversation

ruchiramoitra
Copy link
Contributor

@ruchiramoitra ruchiramoitra commented May 4, 2020 •
edited by SumanthPuram
Loading

This change is Reviewable

@ruchiramoitra ruchiramoitra requested a review from arnabp92 May 4, 2020 09:48
@arnabp92 arnabp92 requested a review from sayan-rudder May 11, 2020 19:20
sayan-rudder
sayan-rudder approved these changes May 12, 2020
View reviewed changes
Copy link
Contributor

@sayan-rudder sayan-rudder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems like npm run buildProdBrowser is failing from the test.
will merge and then check once

@sayan-rudder sayan-rudder merged commit ad821f9 into master May 12, 2020
@akashrpo akashrpo deleted the fb_pixel_dest branch March 5, 2022 10:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayan-rudder sayan-rudder sayan-rudder approved these changes

@arnabp92 arnabp92 arnabp92 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ruchiramoitra @arnabp92 @sayan-rudder