Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feature(new integration): Vero web Device mode integration onboarding-production #556

Merged
merged 1 commit into from
Jul 11, 2022

Conversation

sauravlal-rudderstack
Copy link
Contributor

@sauravlal-rudderstack sauravlal-rudderstack commented Jul 11, 2022

Description of the change

Vero web Device mode integration onboarding-production

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@github-actions
Copy link

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
Core - CDN 36.51 KB (+0.35% 🔺) 731 ms (+0.35% 🔺) 147 ms (-10.7% 🔽) 877 ms
All Integrations - CDN 611.7 KB (+0.15% 🔺) 12.3 s (+0.15% 🔺) 805 ms (-14.22% 🔽) 13.1 s
Core - NPM 36.68 KB (+0.41% 🔺) 734 ms (+0.41% 🔺) 218 ms (+74.42% 🔺) 951 ms

@saikumarrs saikumarrs changed the base branch from production to production-staging July 11, 2022 14:11
@saikumarrs saikumarrs merged commit e18e99c into production-staging Jul 11, 2022
@saikumarrs saikumarrs deleted the feature/Vero-new-integrations branch July 11, 2022 14:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants