Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Use standard library for UUID generation #554

Merged
merged 3 commits into from
Jul 11, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented Jul 11, 2022

Description of the change

Replaced the custom UUID generation logic in the SDK with @lukeed/uuid to ensure fewer collisions in the IDs. This will be used by messageId and anonymousId.
Moreover, the messageId format has been updated to match other client SDKs.

New message ID format: <timestamp>-<uuid>.
Note: The timestamp is in microseconds (with at least 100 microseconds resolution).

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs marked this pull request as ready for review July 11, 2022 09:31
@saikumarrs saikumarrs requested a review from MoumitaM as a code owner July 11, 2022 09:31
@saikumarrs saikumarrs merged commit f89649b into v1-staging Jul 11, 2022
@saikumarrs saikumarrs deleted the fix/uuid_upgrade branch July 11, 2022 09:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants