Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Page call event name for Adroll #536

Merged
merged 1 commit into from
May 31, 2022
Merged

Fix: Page call event name for Adroll #536

merged 1 commit into from
May 31, 2022

Conversation

yashasvibajpai
Copy link
Member

@yashasvibajpai yashasvibajpai commented May 31, 2022 •
edited by SumanthPuram
Loading

Description of the change

Fix page call event name structure from from name category to category name.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@yashasvibajpai yashasvibajpai requested a review from ItsSudip May 31, 2022 11:55
@yashasvibajpai yashasvibajpai changed the title Patch: Fix page call event name for Adroll Fix: Page call event name for Adroll May 31, 2022
@utsabc utsabc merged commit 9f71c9d into v1-staging May 31, 2022
@utsabc utsabc deleted the bugfix/adroll-page-call-name-fix branch May 31, 2022 14:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@utsabc utsabc utsabc approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

@ItsSudip ItsSudip Awaiting requested review from ItsSudip

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@yashasvibajpai @utsabc @saikumarrs