Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat: Added group APIs #527

Merged
merged 3 commits into from
Jun 9, 2022
Merged

Feat: Added group APIs #527

merged 3 commits into from
Jun 9, 2022

Conversation

saikumarrs
Copy link
Member

@saikumarrs saikumarrs commented May 30, 2022 •
edited by SumanthPuram
Loading

Description of the change

Added group APIs.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

N/A

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@saikumarrs saikumarrs self-assigned this May 30, 2022
@saikumarrs saikumarrs requested a review from MoumitaM as a code owner May 30, 2022 15:15
@saikumarrs saikumarrs changed the base branch from production to production-staging May 30, 2022 15:15
@github-actions
Copy link

github-actions bot commented May 30, 2022 •
edited
Loading

size-limit report 📦

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/rudder-analytics.min.js 36.42 KB (+0.12% 🔺) 729 ms (+0.12% 🔺) 330 ms (-8.99% 🔽) 1.1 s

MoumitaM
MoumitaM requested changes Jun 7, 2022
View reviewed changes
analytics.js Show resolved Hide resolved
@saikumarrs saikumarrs merged commit 86efec9 into production-staging Jun 9, 2022
@saikumarrs saikumarrs deleted the feature/group-apis branch June 9, 2022 06:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MoumitaM MoumitaM MoumitaM approved these changes

Assignees

@saikumarrs saikumarrs

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@saikumarrs @MoumitaM