Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align Ready method's behaviour #522

Merged
merged 7 commits into from
May 30, 2022
Merged

Align Ready method's behaviour #522

merged 7 commits into from
May 30, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented May 30, 2022

Description of the change

This PR is regarding the changes we made in ready API logic to align the behavior

  • If integrations are loaded or no integration is available for loading then execute the callbacks immediately
  • Else store the callbacks in an array that will be executed after loading completes.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM marked this pull request as ready for review May 30, 2022 05:17
@MoumitaM MoumitaM requested a review from saikumarrs as a code owner May 30, 2022 05:17
@MoumitaM MoumitaM self-assigned this May 30, 2022
@MoumitaM MoumitaM added the Ready for review Changes are ready to be reviewed label May 30, 2022
@MoumitaM MoumitaM requested a review from pallabmaiti May 30, 2022 06:30
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
MoumitaM and others added 4 commits May 30, 2022 14:18
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
Co-authored-by: Sai Kumar Battinoju <[email protected]>
@MoumitaM MoumitaM requested a review from saikumarrs May 30, 2022 09:18
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
analytics.js Outdated Show resolved Hide resolved
MoumitaM and others added 2 commits May 30, 2022 14:53
@MoumitaM MoumitaM requested a review from saikumarrs May 30, 2022 09:30
@MoumitaM MoumitaM merged commit b4c1c06 into v1-staging May 30, 2022
@MoumitaM MoumitaM deleted the feat.alignReadyMethod branch May 30, 2022 09:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants