Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: Allow API calls before load #507

Merged
merged 10 commits into from
Apr 29, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Apr 25, 2022

Description of the change

This feature will enable the SDK methods to be called before load.

  • All the previously called methods will be pushed to the call stack after load in the same order.
  • Ex: Say the call stack currently have [page, identify, load, track]. It will become [load, page, identify, track]

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs as a code owner April 25, 2022 11:36
@MoumitaM MoumitaM requested a review from pallabmaiti April 25, 2022 11:36
@saikumarrs saikumarrs linked an issue Apr 25, 2022 that may be closed by this pull request
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 26, 2022 10:21
analytics.js Outdated Show resolved Hide resolved
Copy link
Member

@saikumarrs saikumarrs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Added requested changes as comments.

@MoumitaM MoumitaM requested a review from saikumarrs April 27, 2022 05:39
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 28, 2022 11:36
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 28, 2022 12:19
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 28, 2022 14:45
analytics.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM requested a review from saikumarrs April 28, 2022 18:37
@saikumarrs saikumarrs merged commit ef784d1 into v1-staging Apr 29, 2022
@saikumarrs saikumarrs deleted the feature/allow-calls-before-load branch April 29, 2022 04:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow firing methods that are called before the load method
2 participants