Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing discrepancy with cloud mode Facebook_Pixel. #480

Merged
merged 1 commit into from
Mar 22, 2022

Conversation

ItsSudip
Copy link
Member

@ItsSudip ItsSudip commented Mar 22, 2022

Description of the change

Here we are upgrading the js-sdk for facebook pixel as there are some discrepancy with the cloud mode mappings.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ItsSudip ItsSudip requested a review from utsabc as a code owner March 22, 2022 05:51
@saikumarrs saikumarrs merged commit d195cf6 into v1-staging Mar 22, 2022
@saikumarrs saikumarrs deleted the fbPixel-discrepency branch March 22, 2022 05:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants