Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

beacon fallback added #460

Merged
merged 2 commits into from
Feb 17, 2022
Merged

beacon fallback added #460

merged 2 commits into from
Feb 17, 2022

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Feb 16, 2022 •
edited by SumanthPuram
Loading

Description of the change

  • If sendBeacon is not available it will fallback to XHR
  • change the data format from "application /json" to "text/plain" for sendBeacon.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from saikumarrs February 16, 2022 09:22
@MoumitaM MoumitaM requested a review from saikumarrs February 16, 2022 10:28
@saikumarrs saikumarrs merged commit f6c4be4 into production-staging Feb 17, 2022
@saikumarrs saikumarrs deleted the fix/sendbeacon branch February 17, 2022 05:29
saikumarrs added a commit that referenced this pull request Feb 17, 2022
@saikumarrs
Merge pull request #461 from rudderlabs/production-staging
ae49b2d 
Staging -> production [beacon fallback added (#460)]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs approved these changes

@pallabmaiti pallabmaiti pallabmaiti approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@MoumitaM @pallabmaiti @saikumarrs