Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix Posthog : added 'persistence' field in options set in init() #413

Merged
merged 3 commits into from
Jan 6, 2022
Merged

Bugfix Posthog : added 'persistence' field in options set in init() #413

merged 3 commits into from
Jan 6, 2022

Conversation

abandonned
Copy link
Contributor

@abandonned abandonned commented Jan 5, 2022 •
edited by SumanthPuram
Loading

Description of the change

Added persistence: "localStorage+cookie" in options set of init() and some minor formattings.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@abandonned abandonned added the Ready for review Changes are ready to be reviewed label Jan 5, 2022
@abandonned abandonned requested a review from saikumarrs January 5, 2022 09:15
@abandonned abandonned self-assigned this Jan 5, 2022
@saikumarrs saikumarrs requested a review from akashrpo January 5, 2022 09:16
akashrpo
akashrpo approved these changes Jan 5, 2022
View reviewed changes
Copy link
Contributor

@akashrpo akashrpo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

saikumarrs
saikumarrs requested changes Jan 5, 2022
View reviewed changes
integrations/Posthog/browser.js Outdated Show resolved Hide resolved
@saikumarrs saikumarrs merged commit 09bb23c into production-staging Jan 6, 2022
@saikumarrs saikumarrs deleted the posthog branch January 6, 2022 04:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akashrpo akashrpo akashrpo approved these changes

@saikumarrs saikumarrs saikumarrs approved these changes

Assignees

@abandonned abandonned

Labels
Ready for review Changes are ready to be reviewed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@abandonned @akashrpo @saikumarrs