-
Notifications
You must be signed in to change notification settings - Fork 85
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PostAffiliatePro Integration #378
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saikumarrs
reviewed
Dec 2, 2021
saikumarrs
reviewed
Dec 6, 2021
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
saikumarrs
added a commit
that referenced
this pull request
Dec 7, 2021
* add dist files * Snap Pixel Initial Commit * add cookie data check and reformat code Signed-off-by: Akash Gupta <[email protected]> * add cases for empty payload Signed-off-by: Akash Gupta <[email protected]> * modified payload mapping Signed-off-by: Akash Gupta <[email protected]> * add edge cases and refactor code Signed-off-by: Akash Gupta <[email protected]> * trim the event value Signed-off-by: Akash Gupta <[email protected]> * add log and change event name Signed-off-by: Akash Gupta <[email protected]> * minor update * remove page_view event from the list Signed-off-by: Akash Gupta <[email protected]> * update custom event list * refactor event names in object * refactor event names * ProfitWell Initial Commit * refactor code * refactor code * remove cookieData * remove throw error message * correct payload key * update profitwell identify * remove unused import * Delete test-tool.yaml * move marketing tracking to identify * add isLoaded and isReady check * change log level to debug * initial commit without rewrite frames * review comment addressed for initial commit * commit without rewrite frames * initial commit for rewriteFrames * logger addition, object to array conversion and formatting * event not dropped if username, email or id is not present * adding set release by property * refactored code * include paths handling edited * mandatory field checks reverted and scriploader edit * edits after end to end test * edit in traits and object to array function * minor update * edit in config * init code transferred to isReady for loading issue * code refactored and ready is modified * minor update * update identify * update scriptloader id * edit in rewriteFrames for ForEach * Enhancement: Updated dist for npm - .Updated gitignore to exclude npm package dir - npm version updated to 1.0.19 - README.md updated to latest * resolved conflicts, added Quatum metric integration * changed config setting to siteID * QuatumMetric-int:Addressed Review comments * QuatumMetric-int:Removed siteID * Feature: Allow Pinterest top-level property mapping i.e. revenue -> value (#322) * removed checkout_id support and replaced it with order_id to align better with ecomm spec * added feature to allow for toplevel property mapping * removed bug that strips property key value pairs * Feature: Configure storage type from options (#336) * Initial cut to configure storage type from options * Update option parameter name * Code-refactored and minor bug fixed * Merge remote-tracking branch 'origin/production' into production-staging * Update .gitignore to exlude index.js (npm package) * Deleted index.js (npm package) file * Updated npm package version to match the SDK * Deleted index.js (npm package) file * Bug Fix: Prevent rudder element mutation by deep copying (#362) * deep cloning rudderElement * renaming the cloned rudderElement * Bumped version * PostAffiliatePro Integration (#378) * Initial commit for PostAffiliatePro * Commit for PostAffiliatePro * Commit for PostAffiliatePro * Commit for PostAffiliatePro * Adding comments. Co-authored-by: sayan-mitra <[email protected]> Co-authored-by: Akash Gupta <[email protected]> Co-authored-by: anuraj <[email protected]> Co-authored-by: Utsab Chowdhury <[email protected]> Co-authored-by: shrouti <[email protected]> Co-authored-by: dalyd14 <[email protected]> Co-authored-by: dalyd14 <[email protected]> Co-authored-by: Ruchira <[email protected]> Co-authored-by: Arnab Pal <[email protected]> Co-authored-by: shrouti1507 <[email protected]> Co-authored-by: Moumita Mandal <[email protected]> Co-authored-by: Sudip Paul <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is