Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix/brave browser #307

Merged
merged 3 commits into from
Aug 17, 2021
Merged

Fix/brave browser #307

merged 3 commits into from
Aug 17, 2021

Conversation

MoumitaM
Copy link
Contributor

@MoumitaM MoumitaM commented Aug 13, 2021 •
edited by SumanthPuram
Loading

Description of the change

Brave browser detection and add it to the userAgent in RudderContext

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@MoumitaM MoumitaM requested a review from arnab-p August 13, 2021 06:30
saikumarrs
saikumarrs reviewed Aug 13, 2021
View reviewed changes
utils/RudderContext.js Outdated Show resolved Hide resolved
@MoumitaM MoumitaM merged commit 782e6c4 into production-staging Aug 17, 2021
@akashrpo akashrpo deleted the fix/brave-browser branch March 5, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saikumarrs saikumarrs saikumarrs left review comments

@arnab-p arnab-p Awaiting requested review from arnab-p

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MoumitaM @saikumarrs