Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Lytics typo #284

Merged
merged 1 commit into from
Aug 3, 2021
Merged

Lytics typo #284

merged 1 commit into from
Aug 3, 2021

Conversation

ryanmccrary
Copy link
Contributor

@ryanmccrary ryanmccrary commented Jul 28, 2021 •
edited by SumanthPuram
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@ryanmccrary ryanmccrary changed the base branch from production to master July 28, 2021 22:17
arnab-p
arnab-p previously approved these changes Jul 29, 2021
View reviewed changes
@arnab-p
Copy link
Contributor

arnab-p commented Jul 29, 2021

@ryanmccrary The PR needs to be against the production branch.

ruchiramoitra
ruchiramoitra previously approved these changes Jul 29, 2021
View reviewed changes
@ruchiramoitra ruchiramoitra changed the base branch from master to production July 29, 2021 09:29
@ruchiramoitra ruchiramoitra dismissed stale reviews from arnab-p and themself July 29, 2021 09:29

The base branch was changed.

@arnab-p
Copy link
Contributor

arnab-p commented Jul 29, 2021

Changing the base branch brought a lot of unnecessary changes. Let's create a fresh PR only with @ryanmccrary's changes

@ryanmccrary
Copy link
Contributor Author

Sorry about that, based off production now @arnab-p

@arnab-p arnab-p merged commit 2f66cab into production Aug 3, 2021
@arnab-p arnab-p deleted the lytics-typo branch August 3, 2021 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruchiramoitra ruchiramoitra ruchiramoitra approved these changes

@arnab-p arnab-p arnab-p left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ryanmccrary @arnab-p @ruchiramoitra