Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reddit Pixel integration #272

Merged
merged 8 commits into from
Jul 25, 2021
Merged

Reddit Pixel integration #272

merged 8 commits into from
Jul 25, 2021

Conversation

akashrpo
Copy link
Contributor

@akashrpo akashrpo commented Jul 19, 2021 •
edited by SumanthPuram
Loading

add RedditPixel device-mode integration

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@arajguha arajguha changed the base branch from production to production-staging July 19, 2021 08:58
@akashrpo
Reddit Pixel integration
c541af7 
add RedditPixel device-mode integration
@arajguha arajguha merged commit 3ea562d into production-staging Jul 25, 2021
@akashrpo akashrpo deleted the reddit_pixel branch March 5, 2022 10:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arajguha arajguha arajguha left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@akashrpo @arajguha