Adobe Analytics #250
Merged
Adobe Analytics #250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arnab-p
reviewed
Jun 8, 2021
Comment on lines
+73
to
+75
| "Adobe Analytics": "ADOBE_ANALYITCS", | ||
| ADOBE_ANALYTICS: "ADOBE_ANALYTICS", | ||
| AdobeAnalytics: "ADOBE_ANALYTICS", |
There was a problem hiding this comment.
Let's support all lowercases as well?
integrations/AdobeAnalytics/util.js
Outdated
| * @param {} return true or false accordingly if value is empty | ||
| */ | ||
|
|
||
| function isEmpty(value) { |
There was a problem hiding this comment.
Let's not mix ES5 and ES6 and fix on ES6.
integrations/AdobeAnalytics/util.js
Outdated
| value === undefined || | ||
| value === null || | ||
| (typeof value === "object" && Object.keys(value).length === 0) || | ||
| (typeof value === "string" && value.trim().length === 0) |
There was a problem hiding this comment.
Should we handle array as well?
| @@ -0,0 +1,69 @@ | |||
| /* eslint-disable no-param-reassign */ | |||
There was a problem hiding this comment.
It'd be nice to move this file to a common util file.
|
|
||
| // Begin heartbeat implementation | ||
|
|
||
| populatHeartbeat(rudderElement) { |
There was a problem hiding this comment.
Suggested change
| populatHeartbeat(rudderElement) { | |
| populateHeartbeat(rudderElement) { |
typo?
| campaign = properties.campaign; | ||
| } | ||
| const channel = rudderElement.message.channel || properties.channel; | ||
| const { state, zip } = properties; |
| const key = rudderProp.productMerchProperties.split("."); | ||
| // take the keys after products. and find the value in properties | ||
| const value = _.get(properties, key[1]); | ||
| if (value && value !== "undefined") { |
There was a problem hiding this comment.
Check similar implementations and figure out if we can move it to a util method
arnab-p
approved these changes
Jun 11, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is