onboarding clevertap #219
onboarding clevertap #219
Conversation
integrations/Clevertap/browser.js
Outdated
| ? "https://d2r1yp2w7bby2u.cloudfront.net/js/a.js" | ||
| : "http://static.clevertap.com/js/a.js"; | ||
|
|
||
| ScriptLoader("clevertap-integration", sourceUrl); |
There was a problem hiding this comment.
let's do this after the below part.
though same thing but still :)
integrations/Clevertap/browser.js
Outdated
|
|
||
| isLoaded() { | ||
| logger.debug("in clevertap isLoaded"); | ||
| return !!window.clevertap && window.clevertap.logout !== "undefined"; |
There was a problem hiding this comment.
"undefined" --> undefined
| logger.debug("in clevertap identify"); | ||
|
|
||
| const { message } = rudderElement; | ||
| if (!(message.context && message.context.traits)) { |
There was a problem hiding this comment.
is payload with only identity invalid?
i.e not traits but only userId/anonymousId?
There was a problem hiding this comment.
Wehn identify is called without traits or id i.e rudderanalytics.identify() by default, SDK is generating an empty object for traits. I don't think this block will be executed, still, should we keep it for any kind of future SDK changes fail-safety?
| logger.debug(`Error occured at extractCustomFields ${err}`); | ||
| } | ||
|
|
||
| window.clevertap.onUserLogin.push({ |
There was a problem hiding this comment.
should we use the window.clevertap.profile.push ? not sure I think onUserLogin is what is documented.
still check once
There was a problem hiding this comment.
think something to do. with the clevertap native sdk behaviour we observed
integrations/Clevertap/browser.js
Outdated
| logger.debug("in clevertap track"); | ||
| const { event, properties } = rudderElement.message; | ||
| if (properties) { | ||
| window.clevertap.event.push(event, properties); |
There was a problem hiding this comment.
try sending inner objects or arrays. check if that as property is supported
There was a problem hiding this comment.
this is only supported in charged events we should use a validator for other events for checking if arrays or objects are are present
utils/utils.js
Outdated
| * To check if a variable is storing object or not | ||
| */ | ||
| const isObject = (obj) => { | ||
| return Object.prototype.toString.call(obj) === '[object Object]'; |
There was a problem hiding this comment.
let's use the type method present in the utils
utils/utils.js
Outdated
| * To check if a variable is storing object or not | ||
| */ | ||
| const isArray = (obj) => { | ||
| return Object.prototype.toString.call(obj) === '[object Array]'; |
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is