Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added Group call support for GA4 #192

Merged
merged 1 commit into from
Oct 7, 2021
Merged

Added Group call support for GA4 #192

merged 1 commit into from
Oct 7, 2021

Conversation

Shivam4415
Copy link
Contributor

@Shivam4415 Shivam4415 commented Jan 12, 2021 •
edited by SumanthPuram
Loading

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

@arnab-p arnab-p requested a review from ruchiramoitra June 3, 2021 05:16
Base automatically changed from production-staging to production June 21, 2021 13:09
@saikumarrs saikumarrs merged commit 392eb3f into production Oct 7, 2021
@akashrpo akashrpo deleted the ga4-group/production-staging branch March 5, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sayan-mitra sayan-mitra sayan-mitra left review comments

@ruchiramoitra ruchiramoitra ruchiramoitra approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Shivam4415 @sayan-mitra @ruchiramoitra @saikumarrs