Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Production -> master #183

Merged
merged 127 commits into from
Jan 15, 2021
Merged

Production -> master #183

merged 127 commits into from
Jan 15, 2021

Conversation

sayan-mitra
Copy link
Contributor

@sayan-mitra sayan-mitra commented Jan 4, 2021

Description of the change

Description here

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

desusai7 and others added 25 commits December 23, 2020 12:43
GA4 Bug fixes- added logic of sendUserId in init function when script…
GA4 Bug fixes- flattening track call json payload
GA4 Bug fixes- page view will not trigger with identify call when blockPageView flag is true.
@sayan-mitra sayan-mitra requested a review from prabrishac January 4, 2021 14:52
@sayan-mitra sayan-mitra changed the title Production merge Production -> master Jan 4, 2021
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/rudder-analytics.min.js 63.1 KB (+9.38% 🔺) 1.3 s (+9.38% 🔺) 365 ms (+10.93% 🔺) 1.7 s

@sayan-mitra sayan-mitra merged commit f2ae2b7 into master Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants