Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update README.md #172

Merged
merged 1 commit into from
Dec 28, 2020
Merged

Update README.md #172

merged 1 commit into from
Dec 28, 2020

Conversation

ameypv-rudder
Copy link
Contributor

@ameypv-rudder ameypv-rudder commented Dec 16, 2020 •
edited by SumanthPuram
Loading

Description of the change

Config plane references changed to 'Control Plane'. URL updated too.

Type of change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Related issues

Fix #1

Checklists

Development

  • Lint rules pass locally
  • The code changed/added as part of this pull request has been covered with tests
  • All tests related to the changed code pass in development

Code review

  • This pull request has a descriptive title and information useful to a reviewer. There may be a screenshot or screencast attached
  • "Ready for review" label attached to the PR and reviewers mentioned in a comment
  • Changes have been reviewed by at least one other engineer
  • Issue from task tracker has a link to this pull request

This change is Reviewable

github-actions[bot]
github-actions bot reviewed Dec 16, 2020
View reviewed changes
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

size-limit report

Path Size Loading time (3g) Running time (snapdragon) Total time
dist/rudder-analytics.min.js 57.18 KB (0%) 1.2 s (0%) 300 ms (-12.85% 🔽) 1.5 s

@arnab-p arnab-p merged commit 156ef72 into master Dec 28, 2020
@akashrpo akashrpo deleted the readme-update branch March 5, 2022 10:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@github-actions github-actions[bot] github-actions[bot] left review comments

@arnab-p arnab-p arnab-p approved these changes

@sayan-mitra sayan-mitra Awaiting requested review from sayan-mitra

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ameypv-rudder @arnab-p