Pendo sdk #164
Pendo sdk #164
Conversation
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 56.97 KB (-0.38% 🔽) | 1.2 s (-0.38% 🔽) | 333 ms (-2.84% 🔽) | 1.5 s |
integrations/Pendo/browser.js
Outdated
| identify(rudderElement) { | ||
| let visitorObj = {}; | ||
| visitorObj.id = | ||
| rudderElement.message.userId || rudderElement.message.anonymousId; |
There was a problem hiding this comment.
this is correct.. What segment does is I user id is not present they append the anonymous id with PENDO_T . We can implement this too
There was a problem hiding this comment.
Ok will do that, and what u are suggesting is actually correct, it will be easy to understand anonymous user by looking at Prefix :: PENDO_T
integrations/Pendo/browser.js
Outdated
| if (rudderElement.message.context.traits) { | ||
| visitorObj = { | ||
| ...visitorObj, | ||
| ...rudderElement.message.context.traits, |
There was a problem hiding this comment.
please check if nested objects (the traits) are sent if it is being handled by panda or we have to send it as flattened?
There was a problem hiding this comment.
Flattened the traits object and sending it to PendoAgent.
Pendo has an agent section that accepts traits that are sent for that visitor or account.
integrations/Pendo/browser.js
Outdated
| } | ||
|
|
||
| track(rudderElement) { | ||
| window.pendoCli.track(rudderElement.message.event); |
There was a problem hiding this comment.
I checked track events are sent like this in panda sdk --- >
pendo.track("User Registered", {
userId: user.id,
plan: user.plan,
accountType: "Facebook"
});
});
So shouldn't the properties go along with the name of the event?
Here also check about the nested properties.
There was a problem hiding this comment.
Sending properties along with track calls.
We don't need to flatten this properties. Pendo take care of nested objects.
Fixed
| @@ -40,7 +41,7 @@ const integrations = { | |||
| OPTIMIZELY: Optimizely.default, | |||
| BUGSNAG: Bugsnag.default, | |||
| FULLSTORY: Fullstory.default, | |||
| TVSQUARED: TVSquared.default, | |||
There was a problem hiding this comment.
This should not be deleted?
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.53 KB (+0.6% 🔺) | 1.2 s (+0.6% 🔺) | 348 ms (+14.5% 🔺) | 1.5 s |
…pend anonymous id to _Pendo_ prefix
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.77 KB (+1.02% 🔺) | 1.2 s (+1.02% 🔺) | 332 ms (-9.64% 🔽) | 1.5 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.78 KB (+1.03% 🔺) | 1.2 s (+1.03% 🔺) | 411 ms (+25.89% 🔺) | 1.6 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.81 KB (+1.08% 🔺) | 1.2 s (+1.08% 🔺) | 336 ms (+32.69% 🔺) | 1.5 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.75 KB (+1% 🔺) | 1.2 s (+1% 🔺) | 319 ms (+37.87% 🔺) | 1.5 s |
integrations/Pendo/browser.js
Outdated
| group(rudderElement) { | ||
| const obj = {}; | ||
| let accountObj = {}; | ||
| const { traits } = rudderElement.message.context; |
There was a problem hiding this comment.
our group level traits are present at top level.
user traits are present inside context.
I think we need to send both visitor and account object by reading traits from top level and under context.
There was a problem hiding this comment.
Sending both object
integrations/Pendo/browser.js
Outdated
| if (traits) { | ||
| accountObj = { | ||
| ...accountObj, | ||
| ...flattenJsonPayload(traits), |
There was a problem hiding this comment.
also is flatten necessary?
There was a problem hiding this comment.
Removing flatten as Pendo cannot recognize property with dot operator
integrations/Pendo/browser.js
Outdated
| ...accountObj, | ||
| ...flattenJsonPayload(traits), | ||
| }; | ||
| obj.account = accountObj; |
There was a problem hiding this comment.
for account there seems to be a concept of parentAccounts. Can you check that
|
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.75 KB (+1% 🔺) | 1.2 s (+1% 🔺) | 381 ms (+28.82% 🔺) | 1.6 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.71 KB (+0.91% 🔺) | 1.2 s (+0.91% 🔺) | 346 ms (+9.6% 🔺) | 1.5 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.77 KB (+1.02% 🔺) | 1.2 s (+1.02% 🔺) | 318 ms (-0.05% 🔽) | 1.5 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.73 KB (+0.95% 🔺) | 1.2 s (+0.95% 🔺) | 226 ms (-51.89% 🔽) | 1.4 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.71 KB (+0.92% 🔺) | 1.2 s (+0.92% 🔺) | 347 ms (+7.89% 🔺) | 1.6 s |
There was a problem hiding this comment.
size-limit report
| Path | Size | Loading time (3g) | Running time (snapdragon) | Total time |
|---|---|---|---|---|
| dist/rudder-analytics.min.js | 57.69 KB (+0.88% 🔺) | 1.2 s (+0.88% 🔺) | 345 ms (-5.27% 🔽) | 1.5 s |
|
closing this as #167 addresses this |
Description of the change
Type of change
Related issues
Checklists
Development
Code review
This change is