adding xmlhttp as external and other changes

rudder-client-javascript/analytics/package.json

@@ -5,8 +5,10 @@
   "main": "./dist/browser.js",
   "scripts": {
     "test": "echo \"Error: no test specified\" && exit 1",
-    "buildDev": "uglify=\"false\" rollup -c",
-    "buildProd": "uglify=\"true\" rollup -c"
+    "buildDevBrowser": "NODE_ENV=false uglify=false rollup -c",
+    "buildProdBrowser": "NODE_ENV=false uglify=true rollup -c",
+    "buildDevNode": "NODE_ENV=true uglify=false rollup -c",
+    "buildProdNode": "NODE_ENV=true uglify=true rollup -c"
   },
   "author": "",
   "license": "ISC",
@@ -28,6 +30,7 @@
     "rollup-plugin-node-resolve": "^5.2.0",
     "rollup-plugin-replace": "^2.2.0",
     "rollup-plugin-terser": "^5.1.2",
-    "rollup-plugin-uglify": "^6.0.3"
+    "rollup-plugin-uglify": "^6.0.3",
+    "xmlhttprequest": "^1.8.0"
   }
 }

rudder-client-javascript/analytics/rollup.config.js

@@ -6,6 +6,7 @@ import { terser } from "rollup-plugin-terser";
 
 export default {
   input: "analytics.js",
+  external: ["Xmlhttprequest"],
   output: [
     {
       file: "dist/browser.js",
@@ -18,7 +19,9 @@ export default {
     }
   ],
   plugins: [
-    replace({ "process.browser": true }),
+    replace({
+      "process.browser": process.env.NODE_ENV == "true" ? false : true
+    }),
     resolve(),
     commonjs(),
     babel({

rudder-client-javascript/analytics/tests/html/test_browser.html

@@ -5,6 +5,7 @@ <h1>Page Loaded</h1>
 
     <script type="text/javascript">
       analytics = window.analytics = [];
+      XMLHttpRequestNode = XMLHttpRequest;
       analytics.page = function() {
         console.log(...arguments)
         analytics.push(["page", ...arguments]);

rudder-client-javascript/analytics/utils/EventRepository.js

@@ -6,6 +6,7 @@ import {
 import { getCurrentTimeFormatted } from "./utils";
 import { replacer } from "./utils";
 import { RudderPayload } from "./RudderPayload";
+import * as XMLHttpRequestNode from "Xmlhttprequest";
 
 //Event Repository
 class EventRepository {
@@ -33,7 +34,11 @@ class EventRepository {
     payload.sent_at = getCurrentTimeFormatted();
     //server-side integration, XHR is node module
 
-    var xhr = new XMLHttpRequest();
+    if (process.browser) {
+      var xhr = new XMLHttpRequestNode();
+    } else {
+      var xhr = new XMLHttpRequestNode.XMLHttpRequest();
+    }
 
     console.log("==== in flush sending to Rudder BE ====");
     console.log(JSON.stringify(payload, replacer).replace(/rl_/g, ""));

rudder-client-javascript/analytics/utils/utils.js

@@ -1,3 +1,5 @@
+import * as XMLHttpRequestNode from "Xmlhttprequest";
+
 //Utility method for excluding null and empty values in JSON
 function replacer(key, value) {
   if (!value || value == "") {
@@ -39,7 +41,11 @@ function getCurrentTimeFormatted() {
 function getJSON(url, wrappers, isLoaded, callback) {
   //server-side integration, XHR is node module
 
-  let xhr = new XMLHttpRequest();
+  if (process.browser) {
+    var xhr = new XMLHttpRequestNode();
+  } else {
+    var xhr = new XMLHttpRequestNode.XMLHttpRequest();
+  }
   xhr.open("GET", url, false);
   xhr.onload = function() {
     let status = xhr.status;
@@ -60,7 +66,12 @@ function getJSON(url, wrappers, isLoaded, callback) {
 function getJSONTrimmed(context, url, callback) {
   //server-side integration, XHR is node module
   let cb_ = callback.bind(context);
-  let xhr = new XMLHttpRequest();
+
+  if (process.browser) {
+    var xhr = new XMLHttpRequestNode();
+  } else {
+    var xhr = new XMLHttpRequestNode.XMLHttpRequest();
+  }
   xhr.open("GET", url, true);
   xhr.onload = function() {
     let status = xhr.status;